Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NET-8062] Consul-CT compatibility matrix #1923

Merged
merged 2 commits into from
May 7, 2024
Merged

[NET-8062] Consul-CT compatibility matrix #1923

merged 2 commits into from
May 7, 2024

Conversation

kkavish
Copy link
Contributor

@kkavish kkavish commented May 6, 2024 •
edited
Loading

What is in this PR?

  • We have added the compatibility matrix in the README.md which gives everyone a view about how different versions of CT work with different versions of Consul.

Why this PR?

How did we test?

  • We built docker images with Consul and CT binaries inside them, started Consul and then ran all the CT tests to see whether they pass.
  • If they failed we analysed them and checked whether the failure was due to a hardcoded value in the test, removed them and re-ran.
  • The code is checked in here Kkavish/compatibility test #1907

@kkavish
[NET-8062]
c41f20a 
- Added compatibility matrix w.r.t Consul in README.md
@kkavish
[NET-8062]
a8105aa 
- Added compatibility matrix w.r.t Consul in README.md
@kkavish kkavish requested review from david-yu and tgross May 6, 2024 07:29
jmurret
jmurret requested changes May 6, 2024
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description to also include a meaning description of the change so that when reviewing the git log, the commit has a meaning description and not just a unique identifier to a ticketing system.

@kkavish kkavish changed the title [NET-8062] [NET-8062] Consul-CT compatibility matrix May 6, 2024
@kkavish kkavish requested a review from jmurret May 6, 2024 18:17
jmurret
jmurret approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@jmurret jmurret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kkavish kkavish merged commit a47a52e into main May 7, 2024
54 checks passed
@kkavish kkavish deleted the readme_compat branch May 7, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmurret jmurret jmurret approved these changes

@david-yu david-yu david-yu approved these changes

@tgross tgross Awaiting requested review from tgross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkavish @david-yu @jmurret